search

Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
700 stars 145 forks source link

python3.4 support aka PYTHON_TEST_VERSION=3 #81

Closed df7cb closed 10 years ago

df7cb commented 10 years ago

I'm successfully running the regression tests against python 3.4.1 on Debian/unstable. The only thing that is missing for this seems to be a symlink test-3.4 -> test-3.3 which I'm creating on the fly during the build. A cleaner solution seems to be to rename the test dirs to just "test-2" and "test-3" and adjust PYTHON_TEST_VERSION in the Makefile accordingly, i.e. PYTHON_TEST_VERSION ?= $(shell ${PYTHON} --version 2>&1 | cut -d ' ' -f 2 | cut -d '.' -f 1) Does that make sense?

(Not sent as a pull request as that's not what I've actually put in the Debian build.)

rdunklau commented 10 years ago

That makes sense, but I'm sure there will be test adjustements to do in future releases of python 3. So for now, its just a new symlink.