This PR introduces a toggle (-2) to disable pLS duplicate cleaning. This is not meant to be a proposed change, as it both increases the timing and has dramatic physics performance changes, but it serves as a technical change to facilitate more configuration when including Patatrack pixel tracks as input in the future.
This is the master version of the now closed PR #318, and is only possible for merging after the updates in PR #324.
This PR introduces a toggle (-2) to disable pLS duplicate cleaning. This is not meant to be a proposed change, as it both increases the timing and has dramatic physics performance changes, but it serves as a technical change to facilitate more configuration when including Patatrack pixel tracks as input in the future.
This is the master version of the now closed PR #318, and is only possible for merging after the updates in PR #324.
Timing
Before (48e470e0b04c45eb66a33ec7874e27670fe00473)
After (4d2963adaa2db1d226c4efe01be5d217f5106eea)
After (4d2963adaa2db1d226c4efe01be5d217f5106eea) - No pLS duplicate cleaning
Physics validation
Before (48e470e0b04c45eb66a33ec7874e27670fe00473) - After (4d2963adaa2db1d226c4efe01be5d217f5106eea) https://uaf-10.t2.ucsd.edu/~evourlio/SDL/PR334/comparePR334_48e470-PU200_48e470D-PU200/
Before (48e470e0b04c45eb66a33ec7874e27670fe00473) - After (4d2963adaa2db1d226c4efe01be5d217f5106eea) - No pLS duplicate cleaning https://uaf-10.t2.ucsd.edu/~evourlio/SDL/PR334/comparePR334NopLSDupClean_48e470-PU200_48e470D-PU200/
Efficiency seems ~unchanged:
Fake rate largely decreased (I don't fully understand it):
Duplicate rate dramatically increased (as expected, when using the legacy pixel tracks as inputs, as we do currently):
In general, we seem to be exchanging fake rate for duplicate rate. Again, this not meant to be configuration to work with for now.