search

SegmentLinking / TrackLooper

Apache License 2.0
5 stars 14 forks source link

Fix pT3 and pT5 construction #389

Closed ariostas closed 6 months ago

ariostas commented 7 months ago

I fixed the pixelIndexOffsetNeg variable, which was being set incorrectly causing duplicate pT3s and pT5s to be constructed. I also replaced hardcoded values of size_superbins.

ariostas commented 7 months ago

/run standalone /run cmssw

github-actions[bot] commented 7 months ago

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

github-actions[bot] commented 7 months ago

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

VourMa commented 6 months ago

@ariostas Is this ready for review?

ariostas commented 6 months ago

Is this ready for review?

@VourMa yes, it's ready