Closed VourMa closed 3 months ago
cms-data should be in the 2300 IB today.
While I did not get a response from Matti on the fix proposed in #35 , the comments in the cms-sw PR were in line with this solution be more preferred than the others (accelerators_cff or makeProcessModifier).
So, I wanted to propose to add #35 to this "batch 1".
We can already merge this "batch 1" into the cms-sw PR some time as early as this evening CA time.
Anything else we expect to have ready by then or if need to wait, by the meeting time tomorrow?
So, I wanted to propose to add https://github.com/SegmentLinking/cmssw/pull/35 to this "batch 1".
Fine by me.
We can already merge this "batch 1" into the cms-sw PR some time as early as this evening CA time.
Fine by me as well.
The only additional updates I can push right now is the deletion of the (outdated) test scripts and the (outdated) README. Other than that, I wanted to deal with some of the first comments but I am not sure I will manage to do it today/early tomorrow, and they are not super important for now. All in all, give me a couple of hours to clean up a couple of files and then you can merge from my side. I can ping you when I am done.
@slava77 I am done for this batch.
accumulated list of features in the batch:
lstModulesDevESProducer
by attaching it to an unused task by default to get the framework to skip it (not construct) when LST is not used. This fixes unit tests failing withUnable to find plugin 'LSTModulesDevESProducer@alpaka'