Closed VourMa closed 2 weeks ago
I'll check if the CI is working.
/run all
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
The full set of validation and comparison plots can be found here.
Here is a timing comparison:
Evt Hits MD LS T3 T5 pLS pT5 pT3 TC Reset Event Short Rate
avg 44.4 323.8 121.6 47.8 95.0 502.5 133.7 156.9 101.2 2.0 1528.8 981.9+/- 261.3 413.6 explicit_cache[s=4] (target branch)
avg 47.7 324.7 122.2 48.5 96.4 498.8 133.8 156.4 104.8 2.7 1536.0 989.5+/- 261.4 420.5 explicit_cache[s=4] (this PR)
The PR was built and ran successfully with CMSSW. Here are some plots.
![]() |
The full set of validation and comparison plots can be found here.
As per title. The way I did this is the following:
CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch1_devel
by running:RecoTracker/LSTCore
. Everytime I copied a file, I did agit diff
for that file. If the changes were exactly the same as in the TrackLooper PR, I continued the following file. If not, which can happen if the file has been reformatted bycode-format
, I reverted the change withgit checkout -- filename
and modified manually.cmssw
PR, if any (in this case, #31).scram b -j 12 code-checks >& c.log && scram b -j 12 code-format >& f.log
.For instructions on testing the PR, probably #36 would need to be finalized. I will follow up based on the discussion there.
However, locally merging the aforementioned PR, I managed to run the validation for this one. The plots can be found in this link, and are to be compared with the corresponding ones from the validation of SegmentLinking/TrackLooper#408 here. Results match, so this PR is good to go from my side.