Fix typo in T3 code - Githubissues

SegmentLinking / cmssw

CMS Offline Software

http://cms-sw.github.io/

Apache License 2.0

1 stars 1 forks source link

Fix typo in T3 code #44

Closed VourMa closed 2 weeks ago

VourMa commented 2 weeks ago

Porting SegmentLinking/TrackLooper#407.

Closes #43.

VourMa commented 2 weeks ago

/run all

VourMa commented 2 weeks ago

/run all

Tests seem to be skipped. Any idea why? Maybe I don't have the permissions to run them? The ones started by Gavin in his PR run fine.

slava77 commented 2 weeks ago

/run all

ariostas commented 2 weeks ago

Could you try again to see if it works? Forks on Github work a little different, so I had to add an explicit list of users who can run the CI. I'm not sure why it worked for Gavin.

VourMa commented 2 weeks ago

/run all

github-actions[bot] commented 2 weeks ago

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     47.8    324.9    122.4     48.3     96.9    495.7    132.4    156.7    105.3      3.0    1533.4     990.0+/- 264.4     417.7   explicit_cache[s=4] (target branch)
   avg     44.2    322.3    122.7     47.7     96.1    504.4    133.3    156.5    104.2      2.1    1533.6     985.0+/- 263.7     420.9   explicit_cache[s=4] (this PR)

github-actions[bot] commented 2 weeks ago

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks

Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.