Remove LST_IS_CMSSW_PACKAGE flag

SegmentLinking / cmssw

CMS Offline Software

http://cms-sw.github.io/

Apache License 2.0

1 stars 1 forks source link

Remove LST_IS_CMSSW_PACKAGE flag #47

Closed ariostas closed 1 week ago

ariostas commented 2 weeks ago

Now that we fully moved development to the CMSSW repo there's no need to keep the LST_IS_CMSSW_PACKAGE flag since it was meant for cross-compatibility with the original structure.

slava77 commented 2 weeks ago

@ariostas the updates look good. are you still in progress? Please /run all once it's ready to go.

ariostas commented 2 weeks ago

It's ready to go. I made the target be the _devel branch, but if they ask during the review we can port it there too.

github-actions[bot] commented 2 weeks ago

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     44.3    324.4    125.1     50.8     98.2    500.1    132.8    158.5    104.9      3.2    1542.2     997.8+/- 266.9     424.9   explicit_cache[s=4] (target branch)
   avg     44.9    323.1    125.7     50.1     96.8    507.4    134.0    157.6    106.6      3.1    1549.3     997.0+/- 268.3     427.5   explicit_cache[s=4] (this PR)

github-actions[bot] commented 2 weeks ago

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks

Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.