SegmentLinking / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1 stars 1 forks source link

Sync with standalone developments and options for the LSTOutputConverter #9

Closed VourMa closed 1 year ago

VourMa commented 1 year ago

This PR includes the following developments:

The PR has been tested by running the CMSSW configuration on a few events and verifying that the TrackCandidates are the same and that the TrajectorySeed variables make sense (are reasonably close to those of the corresponding TrackCandidates).

Coupled with SegmentLinking/TrackLooper#280.

VourMa commented 1 year ago

scram b -j 12 code-checks >& c.log

When running this, the output file includes a few lines like this:

1190 warnings generated.
Suppressed 1190 warnings (1189 in non-user code, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Is this an issue? In 45cf6f9 I applied all of the changes applied automatically to our code.

slava77 commented 1 year ago

When running this, the output file includes a few lines like this:

I don't think I ever payed attention to the log files as long as the command returned successfully.

VourMa commented 1 year ago

I don't think I ever payed attention to the log files as long as the command returned successfully.

The command returned successfully and everything was updated accordingly, so I think this is ready to be merged.