SeiictyUsui / pydicom

Automatically exported from code.google.com/p/pydicom
0 stars 0 forks source link

Cannot create DicomIter on files with Explicit VR Transfer Syntax UID #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

iterator = dicom.filereader.DicomIter(file)

What is the expected output? 

Iterator is created

What do you see instead?

  File "/usr/lib/python2.6/dist-packages/dicom/filereader.py", line 112, in
__init__
    logger.debug("Using %s VR, %s Endian transfer syntax" %(("Explicit",
"Implicit")[is_implicit_VR], ("Big", "Little")[is_little_endian]))

What version of the product are you using? 0.9.4-1 / Linux

The code in DicomIter.__init__ sets either is_explicit_VR or
is_implicit_VR, but the call to logger.debug is only based on
is_implicit_VR. This can be fixed by getting rid of the is_explicit_VR
variable. I guess the same proble will happen with Big Endian transfer syntax.

Original issue reported on code.google.com by l...@unistra.fr on 8 Mar 2010 at 11:17

GoogleCodeExporter commented 9 years ago
Fixed in personal clone :
http://code.google.com/r/lamy-pydicom/source/detail?r=92fc0ef56eb083840a54b07c05
659faac48cc4a9

Original comment by l...@unistra.fr on 8 Mar 2010 at 1:49

GoogleCodeExporter commented 9 years ago
Thanks for this -- I thought all references to is_explicit_VR had been 
converted, but 
apparently not. I'll fold this in soon and push to the main repository.

Original comment by darcymason@gmail.com on 9 Mar 2010 at 2:37

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 14894de0a4.

Original comment by darcymason@gmail.com on 14 Apr 2010 at 1:42