Closed jsaul closed 7 months ago
@jsaul
The check for the number of components has been recently implemented with DataModel::numberOfComponents() and I recommend using it instead of re-implementing. See https://github.com/SeisComP/main/blob/e6e395a3a36b2f5d766579b8434396cff6abd400/apps/tools/inventory/scinv/check.cpp#L472
For an example.
Should the relaxation be discuss with the community?
DataModel::numberOfComponents
is good news. However, in the code block you are probably referring to I am not only counting components, but collecting the matching streams (usually three) for further handling. Therefore it is not a re-implementation of DataModel::numberOfComponents
.
Regarding discussion with the community. What do you want to discuss and with whom? Whether SeisComP should be enabled to process data from certain STS-1's or not?
Note also that in more than 99 percent of the sensors used, the components are already perpendicular by design. The allowance of up to 5 degrees (rather than one degree) simply reflects the reality of some stations in important networks plus some safety margin.
The allowance of up to 5 degrees (rather than one degree) simply reflects the reality of some stations in important networks plus some safety margin.
True. So if you think that 5 degrees are acceptable and this is common sense, then go for it.
Thanks. And we will address the other issues in separate PRs or commits.
The orientation of three sensor components is supposed to be mutually perpendicular, but this is not always achieved (particularly the separate STS-1 horizontal components). We therefore tolerate up to 5 degrees of deviation from perfect perpendicularity. This includes all deviations from perpendicularity that can be found at least in the global networks.