Parsing of struct in configuration xml crashes scconfig

[luca-s]

I have found an issue on the master branch that doesn't happen on branch v5. Due to the recent changes on master (Add support to extend configuration structs with plugins) I thought this might be related and I am reporting it.

The xml configuration that crashes scconfig can be found here.

The crash is related to this line and it looks like in my case it->second is null. If I add a check on it being null everything works fine, but I don't have the visibility to understand neither the full problem nor the correct bug fix.

Here are the details:

[gempa-jabe]

How can I reproduce it? I copied the description file and added a raw source but no crash happened.

[luca-s]

Interesting. It happens all the time on my system. Let me debug it further and I will be back to you.

[luca-s]

How to reproduce:

• download SeisComP nightly build
• copy raw_plugin.xml to etc/descriptions/
• run scconfig
• create a seedlink profile
• Add a raw source
• After pressing the + button on the raw source scconfig crashes

I am using Ubuntu 22.04

[gempa-jabe]

Ok, could reproduce it. With an existing source it worked so far. Anyway, I am going to check it.

[luca-s]

Thanks!

[gempa-jabe]

Fixed with 6ae0a2ea9a54117b1770325fa7761a8d50b8f97b

[luca-s]

Perfect, that solves the issue. I fixed that myself like that but I wasn't sure it made sense to have a null pointer in there.

[gempa-jabe]

Yes it makes sense if the variable (sources in this example) is not yet set.