SeisComP / main

The SeisComP application layer for data processing and analysis
Other
9 stars 16 forks source link

fdsnws bug: event id is not reported anymore #33

Closed luca-s closed 2 years ago

luca-s commented 2 years ago

Dear developers,

I've noticed that in recent versions of SeisComP a bug was introduced in fdsnws and the event id is not reported anymore. That applies to both text and xml format. The last version that I know it was working fine is 4.4.0 then I tested version 4.7.0 and I saw this bug. I didn't have the time to check what commit caused the bug though.

thanks Luca

luca-s commented 2 years ago

Just a clarification: when I say "event id is not reported" I mean that it is now an empty string, but it used to be the full event id

gempa-jabe commented 2 years ago

Can you give an example request that does not work anymore?

gempa-jabe commented 2 years ago

@gempa-stephan, please check.

luca-s commented 2 years ago

Text output Screenshot from 2021-12-03 17-05-14 csv output Screenshot from 2021-12-03 17-05-33 Quakeml output Screenshot from 2021-12-03 17-05-49 Seiscomp XML output

Screenshot from 2021-12-03 17-06-16

luca-s commented 2 years ago

And with version 4.4.0...

image

image

image

image

gempa-jabe commented 2 years ago

Does scxmldump with 4.7 show the publicID of the event? I have tested it with the current master and I see eventIDs with fdsnws. I am going to test with the latest release 4.8.

gempa-jabe commented 2 years ago

With 4.7.3 I see all eventIDs as well.

gempa-jabe commented 2 years ago

Same behaviour with 4.8.0. I can't reproduce it. Maybe you can create an example database (SQlite3) which exhibits the issue so that we can test with it. I think two events or even just one should be enough.

gempa-jabe commented 2 years ago

I think I found the issue. It only affects PostgreSQL. Can you please try to change https://github.com/SeisComP/main/blob/master/apps/fdsnws/fdsnws/event.py#L761 to AS m_publicID and check if it works?

luca-s commented 2 years ago

That's it, that fixed the issue. Thanks a lot @gempa-jabe