search

SeisComP3 / seiscomp3

SeisComP is a seismological software for data acquisition, processing, distribution and interactive analysis.
Other
111 stars 88 forks source link

Fix XSLT files for SC3ML 0.10 #158

Closed Brtle closed 6 years ago

Brtle commented 6 years ago

I was looking to update the SC3ML ObsPy module with the 0.10 version but the XSLT files doesn't generate valid QuakeML files. The following new fields aren't in the QuakeML:

I don't think they have a corresponding node in the QuakeML so I removed them. I also add a small fix for the arrival weight mapping.

I mainly tested the conversion to the QuakeML format. QuakeML-RT seems good but I didn't test a lot. Let me know if I did something wrong!

gempa-jabe commented 6 years ago

Thanks for pointing out those issues. Lets @gempa-stephan look through that. I don't think that you need to fix all versions because in pre SC3 0.10 the comment.start,end and pdf did not exist.

Brtle commented 6 years ago

If I'm not mistaken, every XSLT files are the same except the version number. Since the changes of the 0.10 version doesn't break the compatibility of older versions, I think it's easier to maintain by fixing all files. I let you choose what you think best. ;-)

gempa-stephan commented 6 years ago

We discussed and validated your timeWeight mapping. Thanks for your input!