search

SeisComP3 / seiscomp3

SeisComP is a seismological software for data acquisition, processing, distribution and interactive analysis.
Other
111 stars 88 forks source link

Add an origin time hint in the AmplitudeProcessor #169

Closed Brtle closed 6 years ago

Brtle commented 6 years ago

I did a magnitude plugin which calculate a magnitude in the AmplitudeProcessor since this magnitude doesn't need amplitudes. However, I need the origin distance, depth but also the origin time. Is it possible to add an hint with the origin time?

I did the changes and it works but I may forgot some things.

gempa-jabe commented 6 years ago

Thank you for contributing the change. It might be indeed helpful to have access to the origin time. Future versions of the API should get access to the origin object itself additionally. Then implementations can pull in any information they like. We will testing it and merge it.

Note that this change will be part of API version 12 which has already some more binary compatibility changes in the pipeline. I will add a changelog entry to src/trunk/libs/seiscomp3/core/version.h.

gempa-jabe commented 6 years ago

It is integrated.

Brtle commented 6 years ago

Thank you!

Where did you put the changes? I don't see anything on master.

gempa-jabe commented 6 years ago

https://github.com/SeisComP3/seiscomp3/commit/df4a067cd0a41f1b9b9ab5ebf5c1713971f903cc

Brtle commented 6 years ago

It seems that I haven't looked closely enough, thanks! :wink: