[scautoloc] Bugfix: correctly read config option autoloc.useManualPicks

[megies]

This option was always "false", regardless of what was specified in config files. The only way to get autoloc.useManualPicks set to "true" was by calling scautoloc on command line with option '--use-manual-picks'.

I think this PR should fix the bug, I can't check myself locally though, since I don't have time to set up compilation right now.

[gempa-jabe]

Thank you very much for the fix. That the parameter is not being read from the configuration files is indeed a mistake. Furthermore the description of the parameter is missing in descriptions/scautoloc.xml, @jsaul.

[jsaul]

Good catch, thanks for the fix!

Strictly speaking autoloc.useManualPicks is "a little" obsolete because it was superseded by autoloc.useManualPicks. The reason is that manual picks normally exist only in the context of a manual origin, and therefore it more straightforward to get them from manual origins along with the respective arrival information (in particular the operator's phase denotation).

Time to clean this up a bit...

[megies]

autoloc.useManualPicks is "a little" obsolete because it was superseded by autoloc.useManualPicks

autoloc.useManualOrigins?

[jsaul]

Yes :)