search

SeisSol / Training

BSD 3-Clause "New" or "Revised" License
11 stars 11 forks source link

dr/cpp related changes #23

Closed Thomas-Ulrich closed 1 year ago

Thomas-Ulrich commented 1 year ago

See here: https://seissol.readthedocs.io/en/latest/breaking-changes-backward-compatibility.html (Actually, I realize that the need for nucleation stress or traction with FL 16 is not documented).

sebwolf-de commented 1 year ago

Thanks. I think at the same time, we should make the docker container point to one specific SeisSol verison for better stability. I suppose to add a git checkout 80a266e3 in the Dockerfile. Then, we would release a version 1.1.0 of the training container afterwards (Internal changes, but user experience doesn't change significantly).

sebwolf-de commented 1 year ago

git checkout 80a266e3

Or git checkout v1.0.0-rc ;-)

Thomas-Ulrich commented 1 year ago

I think it is a good idea. you can push to my branch if you want.