SeisSol / easi

A library for the Easy Initialization of model parameters.
https://easyinit.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Refactor stress components #13

Closed Thomas-Ulrich closed 3 years ago

Thomas-Ulrich commented 3 years ago

Currently, there are 3 stress components in SeisSol, with partial redundancy.

At the end, so far, I kept STRESS_STR_DIP_SLIP_AM for backward compatibility but then users don't know which component to use. Therefore, we could either continue keeping STRESS_STR_DIP_SLIP_AM but insist on its deprecations (see the current state of PR), or drop STRESS_STR_DIP_SLIP_AM.

Also, I would add an extra parameter s_zz in OptimalStress ( to offer the possibility to constrain the magnitude of the stress tensor with s_zz, which at the end seems to make more sense in most cases). This would lead to some of our previous setups needing slight updates in the easi files. (e.g. adding s_zz 0 in OptimalStress, changing STRESS_STR_DIP_SLIP_AM to OptimalStress following the example in the readthedocs).

I hope the aim of the PR is clear, let me know what you think,

Thomas.