search

SeisSol / easi

A library for the Easy Initialization of model parameters.
https://easyinit.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Agreing on a impalaJIT version #57

Open Thomas-Ulrich opened 3 weeks ago

Thomas-Ulrich commented 3 weeks ago

which impalaJIT should we use? probably https://github.com/ravil-mobile/ImpalaJIT is the most advanced, but: https://github.com/SeisSol/easi/blob/master/doc/compiling_dependencies.rst suggests using https://github.com/uphoffc/ImpalaJIT.git as well as https://github.com/SeisSol/SeisSol/blob/master/.ci/docker-cpu/Dockerfile.base#L29

vikaskurapati commented 3 weeks ago

Honestly speaking, I have only used https://github.com/uphoffc/ImpalaJIT.git until now. Is there any reason that we need to switch to https://github.com/ravil-mobile/ImpalaJIT? Performance, more functionalities or otherwise?

Thomas-Ulrich commented 3 weeks ago

@ravil-mobile ?

davschneller commented 3 weeks ago

Just to add another suggestion mid-/long-term: we could transpile the ImpalaJIT code to Lua, possibly making ImpalaJIT entirely superfluous (except for potential performance gains, if they exist right now)—while being able to keep the current function maps.

ravil-mobile commented 3 weeks ago

Honestly speaking, I have only used https://github.com/uphoffc/ImpalaJIT.git until now. Is there any reason that we need to switch to https://github.com/ravil-mobile/ImpalaJIT? Performance, more functionalities or otherwise?

https://github.com/uphoffc/ImpalaJIT.git works only for x86. https://github.com/ravil-mobile/ImpalaJIT generates code for all LLVM backends (e.g., x86, arm, powerpc).

If I were you I would move everything to Lua. It is cumbersome to support yet another code-generator/jit-compiler. Secondly, ImpalaJIT is a small calculator-like language with very restricted type system (used to be a bachelor project). So, Lua is more powerful. Performance-wise, this part of SeisSol is not performance critical (i.e., - executed once per SeisSol invocation). By and large, I would prefer flexibility over performance for this part of the code.

vikaskurapati commented 3 weeks ago

Honestly speaking, I have only used https://github.com/uphoffc/ImpalaJIT.git until now. Is there any reason that we need to switch to https://github.com/ravil-mobile/ImpalaJIT? Performance, more functionalities or otherwise?

https://github.com/uphoffc/ImpalaJIT.git works only for x86. https://github.com/ravil-mobile/ImpalaJIT generates code for all LLVM backends (e.g., x86, arm, powerpc).

If I were you I would move everything to Lua. It is cumbersome to support yet another code-generator/jit-compiler. Secondly, ImpalaJIT is a small calculator-like language with very restricted type system (used to be a bachelor project). So, Lua is more powerful. Performance-wise, this part of SeisSol is not performance critical (i.e., - executed once per SeisSol invocation). By and large, I would prefer flexibility over performance for this part of the code.

In that case, I would suggest moving to https://github.com/ravil-mobile/ImpalaJIT and mentioning that no new code-generators would be supported and the new function maps should rather be using Lua somewhere in the documentation so that the older function maps still work on the available architectures.

ravil-mobile commented 3 weeks ago

Honestly speaking, I have only used https://github.com/uphoffc/ImpalaJIT.git until now. Is there any reason that we need to switch to https://github.com/ravil-mobile/ImpalaJIT? Performance, more functionalities or otherwise?

https://github.com/uphoffc/ImpalaJIT.git works only for x86. https://github.com/ravil-mobile/ImpalaJIT generates code for all LLVM backends (e.g., x86, arm, powerpc). If I were you I would move everything to Lua. It is cumbersome to support yet another code-generator/jit-compiler. Secondly, ImpalaJIT is a small calculator-like language with very restricted type system (used to be a bachelor project). So, Lua is more powerful. Performance-wise, this part of SeisSol is not performance critical (i.e., - executed once per SeisSol invocation). By and large, I would prefer flexibility over performance for this part of the code.

In that case, I would suggest moving to https://github.com/ravil-mobile/ImpalaJIT and mentioning that no new code-generators would be supported and the new function maps should rather be using Lua somewhere in the documentation so that the older function maps still work on the available architectures.

I forgot to mention: https://github.com/ravil-mobile/ImpalaJIT is LLVM based; thus, you would need to compile and install LLVM, which is a heavy dependency for users regarding the compilation time. https://github.com/uphoffc/ImpalaJIT.git is light-weight and takes a second to compile (but restricted only to x86 arch.). I remember that there was a bug in https://github.com/ravil-mobile/ImpalaJIT which I didn't have time to fix (this is related to JIT compilation workflow in LLVM).

davschneller commented 2 weeks ago

To forward a suggestion: once we're decided, could we add the repo to the SeisSol org maybe? (via creating an ImpalaJIT repo there, and importing (i.e. uploading) the source code)

Besides, feel free to take note of #58 .