search

SeismicData / asdf-library

Adaptable Seismic Data Format
16 stars 10 forks source link

Test #10

Closed ghost closed 8 years ago

QuLogic commented 8 years ago

Are the gen*.h, parse_sf_parfile.h, and prov_parameter.h include files intended to be part of the public API?

ghost commented 8 years ago

No, they probably shouldn’t’ be public. Do you have any suggestions on how to make them private?

An interface with public API and an implementation class which inherits this interface?

Ref: http://stackoverflow.com/questions/17554515/hiding-private-members-of-c-library

On Sep 4, 2015, at 4:21 AM, Elliott Sales de Andrade notifications@github.com<mailto:notifications@github.com> wrote:

Are the gen*.h, parse_sf_parfile.h, and prov_parameter.h include files intended to be part of the public API?

— Reply to this email directly or view it on GitHubhttps://github.com/SeismicData/asdf-library/pull/10#issuecomment-137676464.

QuLogic commented 8 years ago

Well, they aren't actually #included into the public headers, so I think just moving them into a separate directory (that isn't installed) should work.

See #11.