search

SeismicJulia / SeisMakie.jl

MIT License
1 stars 2 forks source link

Consider using lowercase function names for the plots #13

Closed juliohm closed 3 months ago

juliohm commented 4 months ago

The plots are usually defined as lowercase functions. Uppercase is used for types.

I would also try to follow a convention where you end the recipes with a plot suffix, something like:

fig, ax = seisplot(d, style = ..., kind = ...)
AtilaSaraiva commented 3 months ago

Hello @juliohm , thanks for the input. I agree with your suggestions, although the reason we sticked with the current notation is to maintain feature parity with SeisPlot.jl, but you are right. I'm going to arange for this new style to be adopted and link the PR here.

juliohm commented 3 months ago

Also, seismic data (especially post-stack) could be loaded and visualized with the geospatial data science stack we are building at https://juliaearth.github.io/geospatial-data-science-with-julia

Perhaps we could increase synergy between ecosystems by following this established interface.