search

SeismicSource / sourcespec

Earthquake source parameters from P- and S-wave displacement spectra
https://sourcespec.seismicsource.org
Other
50 stars 12 forks source link

sql_output_outlier #38

Closed krisvanneste closed 1 year ago

krisvanneste commented 1 year ago

Patch to include information about outliers for each parameter in the Stations table in the SQL output.

claudiodsf commented 1 year ago

Hi Kris, thanks for this PR!

And sorry for not reacting to the previous one. I'm back on track now and will evaluate both PR this afternoon 😉

krisvanneste commented 1 year ago

No worries.

claudiodsf commented 1 year ago

Ok for me (after adding the outlier information also for the radiated energy 😉).

Note that I had to increment DB_VERSION since the database schema has changed.

I profited of this change to reorder the fields, so that radiated energy is before distance and azimuth.

Ok to merge after a double-check on your side 👍

krisvanneste commented 1 year ago

Works for me.

claudiodsf commented 1 year ago

Rebased and force-pushed. @krisvanneste, could you double-check?

P.S. I will profit of the DB_VERSION change to make other modifications in the DB, directly on the main branch, after this PR is merged.

claudiodsf commented 1 year ago

Ok, merging!

claudiodsf commented 1 year ago

I pushed 44c5d2d with more DB modifications.

Hopefully, it doesn't break anything 😉

krisvanneste commented 1 year ago

Nice bit of refactoring!

claudiodsf commented 1 year ago

Nice bit of refactoring!

Thanks to Copilot and Sourcery 😉