search

SeisoLLC / zeek-kafka

A Zeek log writer plugin that publishes to Kafka.
Apache License 2.0
45 stars 16 forks source link

Fork and rename the project to zeek-kafka #1

Closed JonZeolla closed 3 years ago

JonZeolla commented 3 years ago

Contributor Comments

This renames the project to zeek-kafka from metron-bro-plugin-kafka. Many of the changes in this PR are based off of other plugins, such as Johanna's PostgreSQL writer, and establishes some basic governance.

TODO

JonZeolla commented 3 years ago

In searching around I found this stackexchange answer. Not sure yet if this indicates any specific action we should take to update copyrights, etc.

JonZeolla commented 3 years ago

In searching around I found this stackexchange answer. Not sure yet if this indicates any specific action we should take to update copyrights, etc.

Looks like https://github.com/SeisoLLC/zeek-kafka/pull/1#pullrequestreview-560513472 addresses this statement. Will add to TODO

JonZeolla commented 3 years ago

e2e tests are now working (it looks like the nitroba issue fixed itself, see seisollc/zeek-kafka#5).

JonZeolla commented 3 years ago

In searching around I found this stackexchange answer. Not sure yet if this indicates any specific action we should take to update copyrights, etc.

Looks like #1 (review) addresses this statement. Will add to TODO

Read through section 4 of the license a few times and did some googling; I think e5e6990 should work, what do you think @ottobackwards? The ASF intentionally leaves out any copyrighting from their recommended notice, but 4b requires notification of modification, and this open source stackexchange post seems to indicate that adding a copyright notice is sufficient.

JonZeolla commented 3 years ago

I'm also considering a CI step to ensure that any modified files since the last commit to hit main have a copyright by the zeek-kafka contributors, what do you think?

ottobackwards commented 3 years ago

@JonZeolla I think we are in agreement right?

JonZeolla commented 3 years ago

I was also considering an old copyright. I say we do that before merging this if we're going to

JonZeolla commented 3 years ago

Ok, per our conversation I also updated the license headers to be the typical apache 2.0 now that is no longer an asf project

ottobackwards commented 3 years ago

Is this ready for review?

JonZeolla commented 3 years ago

Not yet, let me wrap up CI and double check my work.

JonZeolla commented 3 years ago

Ok @ottobackwards this is good for review now

I think the reason why it isn't running the new github actions workflows is because we moved from master to main while this PR has been open. Opened a ticket with GitHub to see if that's the case

JonZeolla commented 3 years ago

@ottobackwards feedback addressed, back to you

JonZeolla commented 3 years ago

GitHub support got back to me and they are opening an internal issue with the Actions team, but they expect that after merging this PR GitHub Actions will be enabled and start running for this and future commits/PRs.