JonZeolla commented 3 years ago

Summary of the contribution

This fixes the issue reported in #17; this is not a breaking change and continues to work in the currently supported version of Zeek.

Testing

Run make e2e

[X] Confirm that any associated issues are indicated in the pull request title
[X] Rebase your PR against the latest commit within the target branch
[X] Include steps to verify and test the intended change
[N/A] Write or update unit tests and/or integration tests to verify your changes
[N/A] Run shellcheck against any new or updated shell scripts, indicating the reasoning behind any disabled checks
[X] Indicate whether or not this is a breaking change
[X] Ensure that any new dependencies are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0

JonZeolla commented 3 years ago

Still working on an issue with the linter (got local repro), which is unrelated to the actual problem this fixes.

ottobackwards commented 3 years ago

@JonZeolla are there really 13 commits for this?

JonZeolla commented 3 years ago

@ottobackwards lol I was troubleshooting a CI issue that I couldn't reproduce locally at first.