SeisoLLC / zeek-kafka

A Zeek log writer plugin that publishes to Kafka.
Apache License 2.0
45 stars 16 forks source link

Fix README installation instructions (Fixes #20) #24

Closed JonZeolla closed 3 years ago

JonZeolla commented 3 years ago

Summary of the contribution

Fixes typos in the installation instructions.

Testing

N/A

Checklist

ckreibich commented 3 years ago

Nice README! I think a quick comment to state that ldconfig might be needed after manual librdkafka installation wouldn't hurt. (I checked the source tarball and while they have ldconfig invocations in there for RPMs and debs, I don't see one for manual installation.)

davehouser1 commented 3 years ago

Agree with @ckreibich. Also I would recommended updating the README example sections. @load packages/zeek-kafka/Seiso/Kafka is listed throughout, but does not exist on install. Change to @load packages/zeek-kafka This is tested and works.