SeitaBV / timely-beliefs

Model data as beliefs (at a certain time) about events (at a certain time).
MIT License
34 stars 6 forks source link

Allow reading beliefs from xlsx files #61

Closed Flix6x closed 3 years ago

Flix6x commented 3 years ago

Not quite sure how to handle the openpyxl dependency required to make this work. What do you recommend?

nhoening commented 3 years ago

You mean you don't want to add it to the required dependencies? In that case we could check if it's installed and if not tell the user that they have to install it manually?

Flix6x commented 3 years ago

That makes sense, but pandas does that already, raising:

ValueError: Your version of xlrd is 2.0.1. In xlrd >= 2.0, only the xls format is supported. Install openpyxl instead.

So leave it as is?