Issue 80 filter by most recent events

SeitaBV / timely-beliefs

Model data as beliefs (at a certain time) about events (at a certain time).

MIT License

34 stars 6 forks source link

Issue 80 filter by most recent events #81

Closed Flix6x closed 2 years ago

Flix6x commented 2 years ago

I do need to adjust some terms I use in tests, but I prefer to do that in a separate PR together with some other ill-named tests and test variables, so this PR focuses on adding functionality only. For example, the "day-after" beliefs are indeed after the fact, but actually on the same day as knowledge time, which is too confusing in the long run. So please consider "day-after" here as just a name to set it apart from "day-ahead".

Flix6x commented 2 years ago

I forgot to mention I'll also rename the most_recent_only argument to most_recent_beliefs_only, but you might have guessed that. I'll add a deprecation warning for the former argument and will make sure it remains working, like I did previously for some other renamed arguments of search_session.