SeitaBV / timely-beliefs

Model data as beliefs (at a certain time) about events (at a certain time).
MIT License
34 stars 6 forks source link

Drop support for Python3.7 #94

Closed nhoening closed 10 months ago

nhoening commented 2 years ago

We rely on SciPy, which from version 1.8.0 on dropped support for Python3.7.

See this line: https://github.com/scipy/scipy/blob/master/setup.py#L31

We can support to install 3.7 by pinning Scipy (and numpy) versions, like we did already for Python3.6 in the setup.py file.

But we won't support functionality anymore, as important code we rely on is moving on.

create-issue-branch[bot] commented 2 years ago

Branch issue-94-Drop_support_for_Python3_7 created!

nhoening commented 10 months ago

@Flix6x do you remember what functionality we won't support as Scipy is moving on? I'm not sure I knew when I wrote this issue.

At the moment, we do distinguish between Python versions like this:

  # scipy's setup requires minimal Python versions
    "scipy<1.6; python_version <= '3.6'",
    "scipy<1.8; python_version <= '3.7'",
    "scipy; python_version > '3.7'"
nhoening commented 10 months ago

We officially do not support Python3.7 anymore, so maybe this issue can be closed?

classifiers = [
    "Programming Language :: Python",
    "Programming Language :: Python :: 3",
    "Programming Language :: Python :: 3.8",
    "Programming Language :: Python :: 3.9",    
Flix6x commented 10 months ago

Agreed.