search

SeiyaKobayashi / zkml-optimization

Optimization for on-chain private machine learning.
MIT License
13 stars 1 forks source link

Refactor GitHub Workflow #26

Closed SeiyaKobayashi closed 1 year ago

SeiyaKobayashi commented 1 year ago

🎨 Overview

~Modified Github workflow to output test coverage as a PR comment once a PR is opened.~ Just refactored some workflow code. Deleted unnecessary code from CloneFactory contract.

🌈 Details

See overview section.

📚 References

github-actions[bot] commented 1 year ago
Coverage Report

SeiyaKobayashi commented 1 year ago

Outputs of hardhat compile command (as well as the generated coverage.json file) are too verbose. Not necessary to implement add-coverage-to-pr-comment feature at this moment.

SeiyaKobayashi commented 1 year ago

test coverage

-----------------------|----------|----------|----------|----------|----------------|
File                   |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-----------------------|----------|----------|----------|----------|----------------|
 src/                  |      100 |    98.98 |    97.14 |      100 |                |
  CloneFactory.sol     |      100 |      100 |      100 |      100 |                |
  IVerifier.sol        |      100 |      100 |      100 |      100 |                |
  IVerifierFactory.sol |      100 |      100 |      100 |      100 |                |
  Verifier.sol         |      100 |      100 |    95.65 |      100 |                |
  VerifierFactory.sol  |      100 |    96.88 |      100 |      100 |                |
 src/libraries/        |      100 |      100 |      100 |      100 |                |
  Bytes.sol            |      100 |      100 |      100 |      100 |                |
  Challenge.sol        |      100 |      100 |      100 |      100 |                |
  MerkleTree.sol       |      100 |      100 |      100 |      100 |                |
-----------------------|----------|----------|----------|----------|----------------|
All files              |      100 |       99 |    97.44 |      100 |                |
-----------------------|----------|----------|----------|----------|----------------|