Seize / joy4

Golang audio/video library and streaming server
MIT License
13 stars 4 forks source link

Framerate converter #4

Closed a-rose closed 5 years ago

a-rose commented 5 years ago

PR Type

Description

Add framerate conversion capabilities using libavfilter. The framerate is automatically converted if the encoder's fps setting doesn't match exactly the input framerate

Notes for your reviewer

JulienBreux commented 5 years ago

@a-rose up for comments

a-rose commented 5 years ago

@a-rose up for comments

I'm almost done cleaning up :)

cedricve commented 3 years ago

@a-rose great. I'm just wondering how to properly calculate the FrameRate if this is note set.

https://github.com/Seize/joy4/blob/master/codec/h264parser/parser.go#L650

a-rose commented 3 years ago

@a-rose great. I'm just wondering how to properly calculate the FrameRate if this is note set.

https://github.com/Seize/joy4/blob/master/codec/h264parser/parser.go#L650

If the timing information is not present, you're probably dealing with variable FPS, as is often the case with mobile video streaming.