Sekai-World / sekai-viewer

Web Database Viewer of Project Sekai
https://sekai.best
GNU General Public License v3.0
328 stars 38 forks source link

fix(musicRecommend): scroll-to-top button overlapped with content #367

Closed s25g5d4 closed 2 years ago

s25g5d4 commented 2 years ago

Description

Use a container to wrap the content, so that some paddings are added to avoid the content overlapping with the scroll-to-top button.

Related Issue

366

Motivation and Context

366

How Has This Been Tested?

tested with local dev server.

Screenshots (if appropriate):

圖片

Additional Notes

This change makes the result table narrower. Alternatively, we can just add some padding at the bottom.

dnaroma commented 2 years ago

I will have access to my computer tomorrow and check this PR. Sorry for the delay.

dnaroma commented 2 years ago

I think making table narrow is not a good idea. I suggested two options:

  1. limit the height to avoid overlapping
  2. make scroll-to-top button invisible (maybe accomplished by 1 as well)
s25g5d4 commented 2 years ago

sorry, I don't get what you mean "limit the height to avoid overlapping". limit the height of which element? and how does it solve the problem?

s25g5d4 commented 2 years ago

I think we can simply add some space below the table. that could avoid the overlapping problem without losing the scroll-to-top button.

dnaroma commented 2 years ago

sorry, I don't get what you mean "limit the height to avoid overlapping". limit the height of which element? and how does it solve the problem?

scroll-to-top button will not show if page is not scrolled, and it is not necessary to have a such button here.

dnaroma commented 2 years ago

Sorry I made a mistake, I tought it is music meta page.