search

Sekai-World / sekai-viewer

Web Database Viewer of Project Sekai
https://sekai.best
GNU General Public License v3.0
328 stars 38 forks source link

feat(Story Reader Live2d) #369

Closed kyokuheishin closed 2 months ago

kyokuheishin commented 2 years ago

Description

Implemented the Live2D version of Story Reader.

Related Issue

N/A

Motivation and Context

Since the Live2D reader has been unavailable for quite a long time, so I implemented it.

How Has This Been Tested?

Screenshots (if appropriate):

image image image

Details

Features Implemented:

TODO:

dnaroma commented 2 years ago

Thanks for your efforts! I will review it asap

dnaroma commented 2 years ago

Hi, I reviewed your work, it's pretty awesome, but some suggestions:

  1. Rename "Show" button to "Load".
  2. Add progress bar to indicate loading progress.
  3. Show "START!" on canvas before start instead of hint text above.
  4. Some model keeps T-pose, motion not applied.
  5. Add "Auto" button or checkbox to allow auto play.

Because too many bugs still exist, I can't approve it for merge it.

kyokuheishin commented 2 years ago
  1. Rename "Show" button to "Load".
  2. Add progress bar to indicate loading progress.
  3. Show "START!" on canvas before start instead of hint text above.
  4. Some model keeps T-pose, motion not applied.
  5. Add "Auto" button or checkbox to allow auto play.

Sorry for not replying for so long, I've been a bit busy lately. Thanks for the review! I've made several UI changes that you suggested. But regarding the T-pose issue, I confirmed that the model loaded the action successfully and the issue only occurs when there are many ( n>= 8 ) characters appearing in a story at the same time, so I think it might be related to the third-party library I'm using. It may take me a while to verify my suspicions.

kyokuheishin commented 2 years ago

Still cannot find why loading 10 models could cause animation not updated, it may be a WebGL performance issue.

The solution now is, to create or destroy the model every time the scenario script tells it to appear or disappear, instead of keeping them in memory.

LazytownSpo666 commented 5 months ago

Is Story Reader Live2D still working?

dnaroma commented 5 months ago

Is Story Reader Live2D still working?

Seems so

LazytownSpo666 commented 5 months ago

Is Story Reader Live2D still working?

Seems so

if it does work, what will you (or anyone) need to run Story Reader Live2D? (Also it's not working on any phone)

dnaroma commented 5 months ago

Is Story Reader Live2D still working?

Seems so

if it does work, what will you (or anyone) need to run Story Reader Live2D?

(Also it's not working on any phone)

Have you tested this branch? I'm not sure if it's still working. As long as you can use current Live2D viewer, you could use the Live2D story reader as well.

LazytownSpo666 commented 3 months ago

Is this feature complete or not?

Also what happened to author of this pull request?!

AbnormalPoof commented 1 month ago

I tried testing this a while back and only got a scuffed build working due to how old the commit is (Most stuff didn't work on my end). This might still work if it's adapted for the current version of Sekai Viewer, but I'm not really sure.

LazytownSpo666 commented 1 month ago

I tried testing this a while back and only got a scuffed build working due to how old the commit is (Most stuff didn't work on my end). This might still work if it's adapted for the current version of Sekai Viewer, but I'm not really sure.

Yep, you tried your best.