Sekai-World / sekai-viewer

Web Database Viewer of Project Sekai
https://sekai.best
GNU General Public License v3.0
323 stars 41 forks source link

[BUG] Unit Member Count Parameter in Skills aren't handle #421

Closed EternalFlower closed 1 year ago

EternalFlower commented 1 year ago

Describe the bug

Skills that depends on how many members in the team aren't being handled properly. Instead being shown as a "##%", it is being shown as "{{46;e}}%" and "{{46;m}}%".

Example: "5秒間 スコアが100%UPする 自身を除き「Vivid BAD SQUAD」メンバーを1人編成する毎にスコアが{{46;e}}%UPし、全員一致で更に{{46;e}}%UPする(最大{{46;m}}%)"

Skill id 15 to 19 contains such variables (skill.json)

The skills are being used in cards id 404 to 407.

To Reproduce

  1. Browse to the card with id 404 to 407

Expected behavior No idea. I don't play JP or have the cards. From reading the skill.json, those variables appears to be constants (10%, max 150%)

Screenshots image

Browser (please complete the following information):

Possible cause and/or solution CardDetail.tsx:162 does not handle "e" and "m" e depends on skillEffects->skillEnhance->activateEffectValue m most likely be e * 5 (since 5 is the max number of cards possible in 1 team)