search

Sekai-World / sekai-viewer

Web Database Viewer of Project Sekai
https://sekai.best
GNU General Public License v3.0
321 stars 41 forks source link

Fix gacha page issues #458

Closed candela97 closed 8 months ago

candela97 commented 8 months ago

Description

Fix some bugs with gacha pages.

Related Issue

N/A

Motivation and Context

Some stuff I'm not quite sure of:

  1. https://github.com/Sekai-World/sekai-viewer/commit/f6e024f77b4d6549c323767f50106531f4d00abd adds 2 new localizable strings, but I'm not sure where the actual strings go
  2. https://github.com/Sekai-World/sekai-viewer/commit/c4b4369a738abd01b1be183128169c6c0f1670ec not sure about this fix, but it works. Images for comparison: Before: before After: after
  3. https://github.com/Sekai-World/sekai-viewer/commit/45607eaec30fbaec85de04b9e19cc54800fc266d some gachas have "fake" pickups that crash the dialog when opened, e.g. https://sekai.best/gacha/313 on the TW server. Not sure if it's a data issue, but I think this section shouldn't show pickups when there aren't actually any (i.e. card weights are all the same)
  4. https://github.com/Sekai-World/sekai-viewer/commit/430e0110a0bc255760d112b0a5e042a171b5fe0d is unrelated to gacha pages, but since this PR adds some new assets I figured I'd include it here. This fixes a crash when viewing newer streaming live pages on the JP server, e.g. https://sekai.best/virtual_live/256

I not quite familiar with TS and React in general, so apologies if I make some rookie mistakes. Feel free to make edits.

How Has This Been Tested?