Seklfreak / Robyul2

🤖 The new bot for the I.O.I discord and some other (Kpop) discords!
https://robyul.chat/
GNU Affero General Public License v3.0
63 stars 18 forks source link

dep: run 'ensure' changes Gopkg.lock #24

Closed chanyoung closed 7 years ago

chanyoung commented 7 years ago

Hello Sekl.

My dependency ensuring generates different Gopkg.lock file with yours. (removing go-agent pkg) I couldn't find the code which is using go-agent package in Robyul2 and running build script without go-agent package was fine.

Is it okay to run without go-agent package? Here is my bash shell log.

park@workpc:~/work/go/src/github.com/Seklfreak/Robyul2$ dep ensure
park@workpc:~/work/go/src/github.com/Seklfreak/Robyul2$ git diff Gopkg.lock
diff --git a/Gopkg.lock b/Gopkg.lock
index 9d1c742..4048119 100644
--- a/Gopkg.lock
+++ b/Gopkg.lock
@@ -176,12 +176,6 @@
   revision = "0598bd43cf51d0375c5bcd3a42e807cc19b3b7d9"

 [[projects]]
-  name = "github.com/newrelic/go-agent"
-  packages = [".","internal","internal/jsonx","internal/logger","internal/sysinfo","internal/utilization"]
-  revision = "29ec3cd1bb2f21d21d36da37dae52695cb2c3a17"
-  version = "v1.9.0"
-
-[[projects]]
   branch = "master"
   name = "github.com/nfnt/resize"
   packages = ["."]
@@ -316,6 +310,6 @@
 [solve-meta]
   analyzer-name = "dep"
   analyzer-version = 1
-  inputs-digest = "bb167ab304632bbb13394546e6bf0f801d8b54a360796069274fc34552b874ae"
+  inputs-digest = "e8b847af43522567addf7dfaf809771c36f708dd8477e8ea7eb55d43bcf96bdd"
   solver-name = "gps-cdcl"
   solver-version = 1
park@workpc:~/work/go/src/github.com/Seklfreak/Robyul2$ ./build.sh 
+ go-bindata -nomemcopy -nocompress -pkg helpers -o helpers/assets.go _assets/
+ go build -o Robyul2 '--ldflags=
-X github.com/Seklfreak/Robyul2/version.BOT_VERSION=0.12-627-gfc85ebe
-X github.com/Seklfreak/Robyul2/version.BUILD_TIME=14:52:04-08/15/17
-X github.com/Seklfreak/Robyul2/version.BUILD_USER=park
-X github.com/Seklfreak/Robyul2/version.BUILD_HOST=workpc' .

Regards, CPark

Seklfreak commented 7 years ago

Hello CPark,

the go-agent package comes from an unfinished new relic module I was working on that isn't in git yet. It will run perfectly fine without go-agent. Sorry for the trouble. I will push a Gopkg.lock file without go-agent later. :)

Greetings, Sebastian

chanyoung commented 7 years ago

Understood, I expect new upcoming newrelic module. :) Closing this and thanks.