search

Seklfreak / discord-image-downloader-go

A simple tool which downloads pictures posted in discord channels of your choice to a local folder.
MIT License
349 stars 90 forks source link

[Twitter] Links with queries download outside twitter handling and cause duplicates #135

Closed Kakkela closed 5 years ago

Kakkela commented 5 years ago

Right now message like this:

https://twitter.com/9clover_/status/1109358498507186178 https://pbs.twimg.com/media/D2U7pnhU8AEl-LS?format=jpg&name=orig https://pbs.twimg.com/media/D2U7qZKVAAAQD08?format=jpg&name=orig

results in 4 images downloaded but

https://twitter.com/9clover_/status/1109358498507186178 https://pbs.twimg.com/media/D2U7pnhU8AEl-LS.jpg:orig https://pbs.twimg.com/media/D2U7qZKVAAAQD08.jpg:orig

will result in 2 images downloaded and 2 duplicates ignored.

So right now bot checks if twitter regexp matches and it requires .jpg or .png in the url, so first set of direct links falls through all the way down the handler list to try without queries. Twitter regexp check should either be improved or have additional check to match this kind of URL formats.