Seklfreak / discord-image-downloader-go

A simple tool which downloads pictures posted in discord channels of your choice to a local folder.
MIT License
354 stars 91 forks source link

Showing the downloader under playing #45

Closed tanja84dk closed 6 years ago

tanja84dk commented 6 years ago

I have a small issue and that that the account is showing data from the downloader as if its playing that game like at this moment its saying "Playing 7 pictures downloaded".

Is it posible to get that removed in some way because I'm thinking som admins would maybe kick and ban people for that

Kakkela commented 6 years ago

Personally I think it's common courtesy to show that you might be downloading images from the server. If Admins don't like it you shouldnt be doing it under discuise either.

And if you are using it on main account and think someone wont like it on server you arent really downloading in, I would suggest moving the downloader to second account and only join on servers you download from.

It's fairly simple to get out of the code and build the bot yourself (or try to submit pull request), but I doubt @Seklfreak is going to change the behaviour.

tanja84dk commented 6 years ago

I'm not using my main account but using my uploader account there is verified some places to upload with because If I dont want the upload to be linked with me even that all I upload is legal

And unfortunally I have no experience in the go programming language so I have no idea of where I should start if I should get the code out and build it myself

Kakkela commented 6 years ago

Could you rephrase that, I don't quite understand what you are trying to say.

EvilWalks commented 6 years ago

@sxnfxsed if you see this, mind explaining real quick how you'd go about running it from source in the console? I'd prefer to have it not show download count, as it keeps over writing whatever game I'm playing, or music I'm listening to, when I'd prefer to be sharing those activities instead.

Thanks.

DrakeTDL commented 6 years ago

@EvilWalks do go run main.go to run it from console.

DreamPhreak commented 6 years ago

Personally what I did was export (or is the correct term "compile"?) into a .exe file for portability to run it from another computer without having to install Go lang onto that computer.

EvilWalks commented 6 years ago

I just get errors when trying to run or build it. So I might have to come back to this another day, when I've managed to work out what I'm doing.

The error both "run" and "build" commands are giving me, is as follows:

main.go:27:2: code in directory C:\Users\skinb\go\src\github.com\mvdan\xurls expects import "mvdan.cc/xurls"

DrakeTDL commented 6 years ago

replace "github.com/mvdan/xurls" on line 27 with "mvdan.cc/xurls"

tanja84dk commented 6 years ago

I guess its imposible to build/compile the source anymore when we dont have the versions there is used at start.

Because when I now tried to compile it after I had changed the xurls line in import, then I get this error after

command-line-arguments

.\main.go:482:28: xurls.Strict.FindAllString undefined (type func() regexp.Regexp has no field or method FindAllString) .\main.go:657:35: xurls.Strict.FindAllString undefined (type func() regexp.Regexp has no field or method FindAllString) .\main.go:724:31: xurls.Strict.FindAllString undefined (type func() *regexp.Regexp has no field or method FindAllString)

tanja84dk commented 6 years ago

and I have tried out from the source files for the newest release

DreamPhreak commented 6 years ago

Found a fix for this which I also added to my fork.

Where it says xurls.Strict.FindAllString, add () after Strict so you'll end up with xurls.Strict().FindAllString

Found this when going through xurls documentation where they explain Strict(), Relaxed(), and something, noticed it was missing, added it, now builds without any problems.