search

Seldaek / monolog

Sends your logs to files, sockets, inboxes, databases and various web services
https://seldaek.github.io/monolog/
MIT License
21.03k stars 1.9k forks source link

New commit 01721704fda causes FireBug to break #152

Closed InputOutput closed 11 years ago

InputOutput commented 11 years ago

ErrorException: Notice: Undefined property: Symfony\Bridge\Monolog\Handler\FirePHPHandler::$sendHeaders in /vagrant/vendor/symfony/symfony/src/Symfony/Bridge/Monolog/Handler/FirePHPHandler.php line 66

tristanbes commented 11 years ago

+1 caused by d8d5f96760425e7870992e0001576dcc56e82eff

ping @Seldaek It's crashing the whole application

tristanbes commented 11 years ago

Thanks ;-)

Seldaek commented 11 years ago

OK I added some BC layer, which I think will work. I don't have a symfony 2.2 project at hand so please run composer update and confirm if it worked :)

If it doesn't work, as a workaround you can require monolog in "1.3.1" explicitly for now.

tristanbes commented 11 years ago

i'll do this right now.

tristanbes commented 11 years ago

@Seldaek PHP Fatal error: Cannot redeclare Monolog\Handler\FirePHPHandler::$sendHeaders in /Volumes/Elao/workspace/6board/vendor/monolog/monolog/src/Monolog/Handler/FirePHPHandler.php on line 59

Seldaek commented 11 years ago

I am a moron, please update again :)

tristanbes commented 11 years ago

Fixed. ;-) :+1:

Seldaek commented 11 years ago

OK thanks. If you can please check that it also still disables it properly, like if you view the headers in chrome it shouldn't contain the firephp headers for example. But I think the patch is alright now.

tristanbes commented 11 years ago

I can confirm that : headers

InputOutput commented 11 years ago

Fixed the problem on my side too, thanks!

hasryan commented 11 years ago

Terribly sorry to see the issues caused by my original commit. We use Monolog in isolation and I was unaware of the impact it could have elsewhere. Apologies for the trouble.

Seldaek commented 11 years ago

No worries, I should have been more cautious with removing protected properties too, anyway everyone is back on track. It's part of the risks (and fun?) of using unstable versions :)