Seldaek / monolog

Sends your logs to files, sockets, inboxes, databases and various web services
https://seldaek.github.io/monolog/
MIT License
20.96k stars 1.9k forks source link

Revert "Mark Logger @final to discourage extension" #1827

Closed nicolas-grekas closed 1 year ago

nicolas-grekas commented 1 year ago

This reverts commit 3cba75ec0926eec177a4a2cd6c977ecddd0fc7c1.

This @final annotation is quite hard to work around in Symfony, see eg https://github.com/symfony/symfony/pull/51229, which is a dead end according to @stof.

But instead of completing the work around, I'd like to propose to simply revert the annotation. This class has no interfaces for its non-PSR methods, and I don't think making the class final helps maintenance significantly (does it?)

On the other hand, the cost of making this final looks high, on our side at least.

:pray: