search

Seldaek / monolog

Sends your logs to files, sockets, inboxes, databases and various web services
https://seldaek.github.io/monolog/
MIT License
21.02k stars 1.9k forks source link

LogglyHandler - incorrect records comparison. #1838

Closed dimasvas closed 1 year ago

dimasvas commented 1 year ago

Monolog version 3.4.0

Loggly does not receive all logs. The reason is an incorrect records comparison in LogglyHandler.

Source reference

Now the code is:

return ($record->level >= $level);

It looks like should be:

return ($record->level->value >= $level->value);

We should compare values properties of records.

omerimzali commented 1 year ago

Hi @dimasvas, I crated a pr for this one. https://github.com/Seldaek/monolog/pull/1841

dimasvas commented 1 year ago

Hi omerimzali! Thank you very much!!!! I have just decorated the handler and created a temporary kludge until a new version of the monolog package with the fix will be released. Thank you again! Looking forward for new monolog fixes.