Remove pointless json_encode availability checks

Seldaek / monolog

Sends your logs to files, sockets, inboxes, databases and various web services

https://seldaek.github.io/monolog/

MIT License

21.04k stars 1.9k forks source link

Remove pointless json_encode availability checks #1919

Closed InvisibleSmiley closed 1 month ago

InvisibleSmiley commented 1 month ago

Fixes #1918.

Seldaek commented 1 month ago

Why this? json ext can still be disabled AFAIK even tho it's enabled by default.

InvisibleSmiley commented 1 month ago

Why this? json ext can still be disabled AFAIK even tho it's enabled by default.

No. As I tried to explain it cannot be disabled anymore. If you don't trust my understanding of the official PHP documentation that I cited, maybe read https://php.watch/versions/8.0/ext-json.

Seldaek commented 1 month ago

Ah sorry I missed the linked issue 🤦🏻‍♂️ Sounds good then, thanks. I missed that change in 8.0