Closed jesse-c closed 4 months ago
bonus: Using a YAML linter tool, the YAML error can be reproduced [1].
[1]
Nested mappings are not allowed in compact mappings at line 324, column 19
Nested mappings are not allowed in compact mappings at line 418, column 19
Nested mappings are not allowed in compact mappings at line 450, column 19
@sakoush: Will do! I'm working through now on if this is a strict blocker or not.
update: Created a ticket. This doesn't necessarily block the Pydantic v2 migration as the changes can still be made, it just may be a bit more manual. I'll know more soon.
Currently, since we don't exit on a command failure, it's been missed that generation is currently broken for the dataplane.
You can see an example in these logs from a previous workflow (https://github.com/SeldonIO/MLServer/actions/runs/8880776962/job/24381621013).
This will now be detected/surfaced.
This allows linting to go on and makes the generation check separate.
The intent is to surface this failure but still let PRs go in, as they currently have, as we don't currently have (some) required status checks.
I've also reduced what's installed for the lint job which dramatically speeds it up. Along with this, I've cleaned up run commands that didn't need multi-line syntax.