Closed ryandawsonuk closed 5 years ago
To be used in https://github.com/SeldonIO/seldon-core/pull/616 , ensuring only pods labelled 'fluentd':'true' are logged.
This would ensure that the label is applied by default, even if the user does not set it. Can then be overridden to false. Am changing the helm charts to provide that option to set to true/false. Would not allow any way to remove the label.
Not entirely clear to me whether we want to do the defaulting in the operator or at the example/chart level. For prometheus we are defaulting in the operator.
To be used in https://github.com/SeldonIO/seldon-core/pull/616 , ensuring only pods labelled 'fluentd':'true' are logged.
This would ensure that the label is applied by default, even if the user does not set it. Can then be overridden to false. Am changing the helm charts to provide that option to set to true/false. Would not allow any way to remove the label.
Not entirely clear to me whether we want to do the defaulting in the operator or at the example/chart level. For prometheus we are defaulting in the operator.