search

SeldonIO / seldon-operator

Seldon Core Operator for Kubernetes
Apache License 2.0
12 stars 10 forks source link

support using envFrom to inject credential in initContainers #50

Closed phsiao closed 5 years ago

phsiao commented 5 years ago

As discussed in https://github.com/SeldonIO/seldon-core/issues/749, using initContainer to download model requires setting up a ServiceAccount and the associated Secret in a specific way so the secret can be placed into the environment variable of the container. In addition, annotation is used to inject the S3 endpoint. This makes things harder than it used to be, and in my opinion, harder than it needs to be.

This PR implements a quick way of retaining the old mechanism via EnvFrom.

phsiao commented 5 years ago

@ryandawsonuk per our discussion, this is how I see it could be implemented. Happy to make adjustments and add support for explainer if this is the right approach.

ryandawsonuk commented 5 years ago

CRD changes for this in https://github.com/SeldonIO/seldon-operator/pull/50