search

SeldonIO / seldon-server

Machine Learning Platform and Recommendation Engine built on Kubernetes
https://www.seldon.io/
Apache License 2.0
1.47k stars 300 forks source link

ConcurrentLinkedHashMap --> Caffeine when Java-8 based #2

Open ben-manes opened 9 years ago

ben-manes commented 9 years ago

When transitioning to requiring Java 8, please upgrade to Caffeine. The performance should be relatively the same and the per-instance memory usage should be smaller.

ConcurrentLinkedHashMap changes will continue to be minimal, even more so now, and driven by requests from Java 6 users unable to upgrade. Caffeine is ideally the upgrade path for Guava cache users too, which due to Android cannot be significantly modified.

ukclivecox commented 9 years ago

Thanks for the info. Certainly be good to test Caffeine as a replacement and see if it helps in load tests when we move to Java 8.

ben-manes commented 9 years ago

If you upgrade from 1.2 to 1.4.2 you'll have much better cache performance, about the same as Caffeine. From there the benefit of upgrading will be better memory management and many more features.

seldondev commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. /lifecycle stale