Seldszar / Gumbo

Swollen companion keeping you updated on your Twitch experience
MIT License
164 stars 7 forks source link

Keep popup open after clicking a link #103

Open PetrP opened 2 years ago

PetrP commented 2 years ago

Version 1.15.0 changed behavior of closing popup after clicking a stream. In particular this window.close line.

Previous ClickBehavior.CreateTab behavior was that the new tab opened with (browser.tabs.create) active: true, but the popup stayed open so multiple steams could be clicked without reopening the popup. I used it to check multiple streams while still browsing gumbo popup before deciding who to watch, without loosing context inside of the popup.

It is possible to open stream with middle-click or with ctrl+click now, which has similar behavior of keeping popup open, but it's with active: false so the last opened stream is not visible, which is worse for my use case.

Closing popup probably makes sense for ClickBehavior.CreateWindow, not sure about ClickBehavior.CreateCurrentTab.

Would you consider reversing the behavior or making it configurable? If you're open to the change but you don't want to do it, then let me know which you prefer and I could make a pull request.