search

Seldszar / Gumbo

Swollen companion keeping you updated on your Twitch experience
MIT License
164 stars 7 forks source link

No streamer category when the notification appears. #109

Closed Mioni closed 1 year ago

Mioni commented 1 year ago

Describe the bug In chrome when the notification appears it says the streamer category in firefox does not appear.

Expected behavior When the notification appears tell which game he is playing.

Screenshots image Here, for example, it was supposed to show that he was on VALORANT.

Desktop (please complete the following information):

CyanSlinky commented 1 year ago

Also happening for me. To me it's more important to see what game the streamer is playing than the stream title, It worked great with earlier versions... not sure what broke it but hopefully this can be fixed.

OS: Windows 10 Browser: Edge Version: 1.16.0

Seldszar commented 1 year ago

Seems like either your browser is using something else than the Chromium notification's UI, which strips the context message where the category name is displayed.

Anyway, I tinkered for a bit on a way to make notifications compliant on all browsers by moving the game name to the title section and the stream title to the message section (cf screenshot below). If that sounds good to you, I'll release this change as soon as possible.

image

CyanSlinky commented 1 year ago

Sounds good to me! I'm not sure why it randomly broke around when the original message was posted (October sometime) From what you said I'm assuming it works in chrome? but it's broken in Edge and presumably in Firefox as well since that's what @Mioni was using when he created the issue. Would love full functionality back but if that's not feasible then your fix should be good. Also, would it be possible to add a setting to toggle your proposed change if people prefer it the other way round.

Thanks for the quick response, really love the extension. 😄