search

Selenium-H / Personalize

A GNOME Shell extension to personalize GNOME looks
GNU General Public License v3.0
16 stars 1 forks source link

Libhandy widgets look different than expected #1

Closed GustavoPeredo closed 3 years ago

GustavoPeredo commented 3 years ago

First I need to say: TYSM for this extension, it is awesome!! That said... There is a problem. Applications that use libhandy widgets look different than expected. Here is an example with GNOME Clocks: Captura de tela de 2021-02-20 08-43-47 You can see that that the buttons on the bottom and titlebar look different than usual. Comparison with how it looks with default Adwaita. Captura de tela de 2021-02-20 08-47-56 If I'm not mistaken, this is caused by using Adwaita's stable version instead of the most recent one... I was mistaken, compiling latest Adwaita theme and using an unmodified css or extracting directly from your system results in the same bug.

GustavoPeredo commented 3 years ago

Good news! Apparently there is a patch you have to add in order to have the widgets to behave correcty! Captura de tela de 2021-02-20 15-40-56

I simply added the lines from Yaru's Adwaita upstream libhandy theme and bam! Now I have to say that unfortunately you would have to have different generators for light and dark variants, otherwise the app looks broken: Captura de tela de 2021-02-20 15-43-35 Using the correct patch (Adwaita-dark.css from the same repository) fixes the issue, tho: Captura de tela de 2021-02-20 15-46-37

GustavoPeredo commented 3 years ago

Also, I've noticed that by default only gtk.css is generated (inside the theme's folder), are you willing to implement gtk.css and gtk-dark.css? This way dark applications, such as GNOME Boxes, behave as intended, or was intentional design to only write gtk.css?

Selenium-H commented 3 years ago

are you willing to implement gtk.css and gtk-dark.css?

Yes.

There is a problem. Applications that use libhandy widgets look different than expected. Here is an example with GNOME Clocks

Working on it. I'll update once done.

GustavoPeredo commented 3 years ago

Awesome!! Thanks!

Selenium-H commented 3 years ago

Added support for libhandy widgets with last commit.