Selenium-H / Personalize

A GNOME Shell extension to personalize GNOME looks
GNU General Public License v3.0
16 stars 1 forks source link

Not fully working on Pop!_OS #3

Open Ricod7 opened 3 years ago

Ricod7 commented 3 years ago

Hello. I'm running Pop!_OS (GNOME 3) and I installed your Personalize Gnome extension directly through the Gnome extensions website. However, it does not apply the dark theme variant to the Shell's top bar menus and, it seems, with certain dialog windows (like when changing the display settings and the dialog that asks if you want to keep the changes or revert back). I atached pics. I'm not sure if it's because the theme is generated in the ~/themes folder as opposed to the themes folder in the root directory or something is not being generated in the Shell theme's code?

I appreciate your help.

Screenshot from 2021-05-25 02-19-24

Screenshot from 2021-05-25 02-21-51

Selenium-H commented 3 years ago

Hi @Ricod7. Sorry for the delayed response. Currently, Dark theme is not applied in top panel and pop up menu since the generated gnome shell theme only changes the accent color related classes in the theme. (I'll try to implement a fix if possible )

with certain dialog windows (like when changing the display settings and the dialog that asks if you want to keep the changes or revert back)

I think it could be Pop!_OS specific issue (I need to test this extension on Pop!_OS)

Kuro-Maii commented 3 years ago

I have found that this extension sets the global theme to the systems light theme, changing that back to dark will preserve the accent color and restores the system overall dark theme.

I hope my finding has helpt with finding the solution to this bug. I am using pop_os 21.04 but considering that the systems global theme is set to light I don't think that the OS matters

edit: this is regardless of the theme selection in this extension

Ricod7 commented 3 years ago

Hi @Ricod7. Sorry for the delayed response. Currently, Dark theme is not applied in top panel and pop up menu since the generated gnome shell theme only changes the accent color related classes in the theme. (I'll try to implement a fix if possible )

with certain dialog windows (like when changing the display settings and the dialog that asks if you want to keep the changes or revert back)

I think it could be Pop!_OS specific issue (I need to test this extension on Pop!_OS)

Thank you for your reply. I just now reinstalled the extention (I have been using other themes instead of the one I generated with this extention) and restored my saved theme generated by this extention in my home & root themes folders to see if the issue was still there. After testing, it still is.

Note: I thank you for your efforts with making your extention, but I have found theme(s) I like using on my system that work for me.

I have found that this extension sets the global theme to the systems light theme, changing that back to dark will preserve the accent color and restores the system overall dark theme.

I hope my finding has helpt with finding the solution to this bug. I am using pop_os 21.04 but considering that the systems global theme is set to light I don't think that the OS matters

edit: this is regardless of the theme selection in this extension

I also recently upgraded my system to pop_os 21.04. I tried what you suggested, but when I go to Gnome Settings to change Appearance from Light back to Dark, the Gnome Tweak Tool Application theme changes to Pop (system Light theme). Changing Appearance from Dark to Light again, changes the Gnome Tweak Tool Application theme to Pop-dark (system Dark theme). Accent colors are not preserved.

Kuro-Maii commented 3 years ago

there is for sure some weird interaction going on. because not every system boot allows the accent color to be applied. reading thru the comment above made me realize that the accent is the system default.... very confusing and makes the extension very unreliable.

looking at gnome tweak tool I see that the extension changes the theme to adawita-personalized which will have the white themed menus, toggling themes around no longer seems to fix things and just makes everything more inconsistent...