search

SeleniumBuilder / se-builder

Legacy Selenium Builder Project
Other
216 stars 104 forks source link

Breaks ability to view saved passwords in Firefox #6

Closed OniOni closed 11 years ago

OniOni commented 11 years ago

When selenium-builder is installed in firefox v. 20, all saved passwords (password manager) disappear. As soon as se-builder is disabled in about:addons they reappear.

This issue seems to have appeared with update to v. 20.

Zarkonnen commented 11 years ago

I managed to replicate this on 20.0a1 (2012-12-24) / OS X using Builder HEAD. I used the following reproduction steps:

Expected: A confirm dialog asking me if I really want to show the passwords.

Observed: No dialogs, and the following error message in the JS console:

Timestamp: 25/12/2012 11:36:40
Error: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "c is undefined" {file: "file:///Users/zar/Projects/SeBuilder/se-builder/se-builder/seleniumbuilder/components/prompt_service.js" line: 5667}]' when calling method: [nsIPromptService::confirmEx]
Source File: chrome://passwordmgr/content/passwordManager.js
Line: 161

I also could replicate that it's Builder's fault:

Expected: A confirm dialog asking me if I really want to show the passwords. Observed: A confirm dialog asking me if I really want to show the passwords.

More distressingly, I could also replicate these problems in Firefox Beta (v18) and Firefox Release (v17).

Zarkonnen commented 11 years ago

Needless to say, this is now at the top of my priority list. Thank you for reporting it!

Zarkonnen commented 11 years ago

This should be fixed now. I've gone through the above repro steps on Firefox 17/18b/20a, and the problem is gone. Can you confirm I fixed the right thing?

OniOni commented 11 years ago

Sorry for the delay in answering.

The problem seems to persist after installing the .xpi built from what I pulled today (02/01/2013).

Here is the error 

Timestamp: 02/01/13 17:45:09
Error: a is null
Source File: file:///home/mathieu/.mozilla/firefox-trunk/zibt03af.default/extensions/seleniumbuilder@saucelabs.com/components/prompt_service.js
Line: 5656

Steps to reproduce:

Expected: Show master password dialogue then show saved passwords window with saved passwords Observed: Show saved passwords window with no login/password.

Disabling se-builder and repeating above steps yields the expected behaviour.

Cheers

Zarkonnen commented 11 years ago

Thanks for verifying that the bug's still extant - we've stopped the presses on Builder 2.0.4, and I'll try to fix it some more!

Zarkonnen commented 11 years ago

I've committed what may be a fix to HEAD. Unfortunately, I am unable to replicate the problem on Nightly on the Mac, and haven't had any success installing Nightly on Linux. Could you check again if the problem's fixed now?

OniOni commented 11 years ago

Your last commit seems to have fixed the issue. I am correctly being prompted for the master password and all my saved passwords are there.

Thanks a bunch.

Zarkonnen commented 11 years ago

Excellent! I will repro/verify the bug is gone on FF 17 Win/Linux/Mac tomorrow and then consider this closed.

Zarkonnen commented 11 years ago

OK, it turns out this had nothing to do with OS version, but rather with whether there's a master password set - which I don't in my dev profile. :) I have now been able to both reproduce the bug on FF 17 and verify it's gone after the latest fix. Thank you again for your help.