search

SeleniumHQ / ansible-selenium

Module for managing a grid / nodes using Ansible
https://galaxy.ansible.com/SeleniumHQ/selenium/
Apache License 2.0
66 stars 43 forks source link

Add role type to pid check? #16

Open kwaping opened 5 years ago

kwaping commented 5 years ago

What do you think about adding role type to pid check? In the current state, you can launch a "hub" type, then set it to status stopped with type "node". This seems unsafe.

If you like the idea, I have a PR ready to go, just have to write some tests and docs. I have tested my code functionally and it works great - can start/stop a hub and node on the same machine independently.

ddavison commented 5 years ago

sounds great @kwaping ! no need to wait on me! send that PR if you still have it handy! :)